> On 十月 26, 2016, 3:22 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, line 700 > > <https://reviews.apache.org/r/50599/diff/15/?file=1543834#file1543834line700> > > > > I would reword this to explicitly mention that tasks launched with the > > docker containerizer require these permissions in order to operate.
Added comments as follow: ``` // NOTE: GPU devices permissions are required to be `rmw` by default, that // is because GPU tasks launched in the container may need to read/write/mknod // to GPU devices in their lifecycle. ``` - Yubo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50599/#review153839 ----------------------------------------------------------- On 十月 24, 2016, 5 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50599/ > ----------------------------------------------------------- > > (Updated 十月 24, 2016, 5 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and > Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Assigned Nvidia GPU devices to docker container based on > GPUs allocated by Nvidia GPU allocator. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 8da63101f951892e673612134770fc155d86112d > src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 > > Diff: https://reviews.apache.org/r/50599/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
