----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53230/#review154106 -----------------------------------------------------------
Fix it, then Ship it! src/tests/health_check_tests.cpp (lines 1662 - 1664) <https://reviews.apache.org/r/53230/#comment223613> Is that `https_server.py` something that you wrote modified? If so, could you please post here links to the dockerfile and the test server? We should make tests transparent and reproducible for anyone. src/tests/health_check_tests.cpp (lines 1978 - 1980) <https://reviews.apache.org/r/53230/#comment223614> Same here. - Alexander Rukletsov On Oct. 27, 2016, 4:06 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53230/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2016, 4:06 p.m.) > > > Review request for mesos, Alexander Rukletsov and Gastón Kleiman. > > > Bugs: MESOS-6493 > https://issues.apache.org/jira/browse/MESOS-6493 > > > Repository: mesos > > > Description > ------- > > Added test cases for HTTPS health check. > > > Diffs > ----- > > src/tests/health_check_tests.cpp b1a8942eb1841f5f795b01e08cb017eedf62c8f4 > > Diff: https://reviews.apache.org/r/53230/diff/ > > > Testing > ------- > > ``` > sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*HealthCheckTest*" > --verbose > ``` > > > Thanks, > > haosdent huang > >
