-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53309/
-----------------------------------------------------------

Review request for mesos, Till Toenshoff, Vinod Kone, and Jiang Yan Xu.


Bugs: MESOS-6455
    https://issues.apache.org/jira/browse/MESOS-6455


Repository: mesos


Description
-------

This test is parameterized, making it run with both the Docker and the
Mesos containerizers.

The test name doesn't contain `DOCKER_`, so the test instantiation that
uses the Docker containerizer will run and fail if Docker is not
available.

Because the test name starts with `ROOT_`, it only runs if root tests
are not filtered, but the Mesos containerizer doesn't need to run as
root.

I extracted a fixture method from the test, so that I could split
`ROOT_TaskUsesExecutor` into `TaskUsesExecutor` and
`ROOT_DOCKER_TaskUsesExecutor`.


Diffs
-----

  src/tests/default_executor_tests.cpp 70779e8d94fbb6e664cad4ddbfeb19e560176cfe 

Diff: https://reviews.apache.org/r/53309/diff/


Testing
-------

`sudo bin/mesos-tests.sh --gtest_filter=DefaultExecutorTest.* --docker=/tmp/foo`
`sudo bin/mesos-tests.sh --gtest_filter=DefaultExecutorTest.*`


Thanks,

Gastón Kleiman

Reply via email to