----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49862/#review154346 -----------------------------------------------------------
Fix it, then Ship it! src/tests/cmake/MesosTestsConfigure.cmake (lines 17 - 19) <https://reviews.apache.org/r/49862/#comment223862> The diff on this entire file appears to be a partial revert of your previous patch. I can remove these changes from the diff, as the other parts are correct and shippable. - Joseph Wu On Oct. 4, 2016, 2:10 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49862/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2016, 2:10 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > Added fles MESOS_DEFAULT_LIBRARY_LINKAGE which is set to STATIC on > WIN32 and SHARED on OSX or Unix. This allows all libraries built > static or shared. Also minor changes made to eliminate leveldb > dependency when build slave or master. Also by setting the flag > CMAKE_POSITION_INDEPENDENT_CODE to true cmake auto sets the > flag -fPIC. > > > Diffs > ----- > > 3rdparty/http-parser/CMakeLists.txt.template > 9a671973b754095e1de917f135a7deb978fb6eb6 > cmake/MesosConfigure.cmake 6650c7c12b188b08c70cfee72b3200e83e7a1cd2 > src/CMakeLists.txt ba49d81335fd47a8ced334e282eadb00657bf2c2 > src/slave/qos_controllers/CMakeLists.txt > 87c92af21c012655c201c01cd4ba5ff912555119 > src/slave/resource_estimators/CMakeLists.txt > 17b149f734ea9dc8ac4c5dd45bdb8312faf4cc77 > src/tests/cmake/MesosTestsConfigure.cmake > 3f543c010ae87ff04e6b45745bc49ef65b6590ff > > Diff: https://reviews.apache.org/r/49862/diff/ > > > Testing > ------- > > cmake .. && make > > > Thanks, > > Srinivas Brahmaroutu > >
