----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52696/ -----------------------------------------------------------
(Updated Nov. 1, 2016, 7:10 p.m.) Review request for mesos, James Peach, Michael Park, and Neil Conway. Changes ------- Only use `-fstack-protector-strong` when it's available. Remove `-Werror` and tackle this in another discussion/JIRA. Bugs: MESOS-6229 https://issues.apache.org/jira/browse/MESOS-6229 Repository: mesos Description ------- Use a default set of flags to provide additional security and hardening to stout. Additionally, check and catch more warnings/errors. Diffs (updated) ----- 3rdparty/stout/Makefile.am 4e10ae2 3rdparty/stout/configure.ac cbb0fdb Diff: https://reviews.apache.org/r/52696/diff/ Testing ------- Compared the benchmarks with and without the flags being used. Also did a comparsion with the flags being used with and without optimizations and without the flags being used with and without optimizations. Overall the performance hit was very small with a 3-8% overhead (optimizations brings this down slightly). Most benchmarks were about 5% (or less) slower. Thanks, Aaron Wood