----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/#review154512 -----------------------------------------------------------
The agent subsystems is a hack to me. I think we should consider support running systemd (or other init system) to manage agent process and put it under proper cgroup using the init system, rather than doing it ourself. - Jie Yu On Nov. 2, 2016, 4:43 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53369/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2016, 4:43 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-6523 > https://issues.apache.org/jira/browse/MESOS-6523 > > > Repository: mesos > > > Description > ------- > > This is to ensure that we do not accept traffic on the agent by opening > up libprocess port only after cgroup assigment for the agent is done. > > > Diffs > ----- > > src/slave/main.cpp 8010f8e229e2d820649750c9db0456ecd1b854d3 > src/slave/slave.cpp d6c337345707993b0729e9eaf36b5a9ecc52dc72 > > Diff: https://reviews.apache.org/r/53369/diff/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >