> On Oct. 31, 2016, 11:11 p.m., Vinod Kone wrote: > > src/tests/default_executor_tests.cpp, lines 219-229 > > <https://reviews.apache.org/r/53266/diff/2/?file=1549156#file1549156line219> > > > > do we use this pattern anywhere else in our test suite? if not, i would > > spend some time to think about alternate patterns.
https://github.com/apache/mesos/blob/master/src/tests/state_tests.cpp#L355 follows a similar pattern. I followed Yan's advice, updating this RR and discarding the rest of the chain. - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53266/#review154342 ----------------------------------------------------------- On Nov. 4, 2016, 5:12 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53266/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 5:12 p.m.) > > > Review request for mesos, Till Toenshoff, Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-6455 > https://issues.apache.org/jira/browse/MESOS-6455 > > > Repository: mesos > > > Description > ------- > > Some of the tests are parameterized by the containerizers. > > Fixed the naming schema, so that the tests using the Docker > containerizer run only if Docker is available. > > Now the tests with the Mesos containerizer also run if the tests > are started as a non-root user. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > db953d39a95e7e95871054114a0a9bbeded46224 > > Diff: https://reviews.apache.org/r/53266/diff/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh --gtest_filter='*DefaultExecutorTest*' > --docker=/tmp/foo` > `sudo bin/mesos-tests.sh --gtest_filter='*DefaultExecutorTest*'` > `bin/mesos-tests.sh --gtest_filter='*DefaultExecutorTest*'` > > > Thanks, > > Gastón Kleiman > >
