----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53330/ -----------------------------------------------------------
(Updated Nov. 4, 2016, 5:16 p.m.) Review request for mesos, Xiaojian Huang, Gilbert Song, Jason Lai, and Jie Yu. Summary (updated) ----------------- Tracked layers and pull latency in docker store. Bugs: MESOS-6451 https://issues.apache.org/jira/browse/MESOS-6451 Repository: mesos Description (updated) ------- This patch added several metrics for docker store: - a counter for number of layers pulled - a gauge for total number of layers - a timer for pull latency distribution in the last hour Diffs (updated) ----- src/slave/containerizer/mesos/provisioner/docker/paths.hpp 232c027f8f96da0cb30b957bce4607d3695050d2 src/slave/containerizer/mesos/provisioner/docker/paths.cpp cd684b33eb308ce1eeb4539a5b2d51985d835db7 src/slave/containerizer/mesos/provisioner/docker/store.cpp e192f86a1848b373f3aa73d29688a96375cac313 Diff: https://reviews.apache.org/r/53330/diff/ Testing (updated) ------- Use mesos-execute to pull several different images, and verified following counters in agent's metrics/snapshot: ``` curl localhost:5051/metrics/snapshot | jq . | grep containerizer/mesos/docker_pull "containerizer/mesos/docker_store/layers_pulled": 47, "containerizer/mesos/docker_store/pull_ms/p50": 7080.760064, "containerizer/mesos/docker_store/pull_ms/p90": 11653.6390912, "containerizer/mesos/docker_store/pull_ms/p9999": 12528.3066648832, "containerizer/mesos/docker_store/pull_ms": 4550.814976, "containerizer/mesos/docker_store/pull_ms/count": 4, "containerizer/mesos/docker_store/pull_ms/max": 12529.182208, "containerizer/mesos/docker_store/pull_ms/p999": 12520.426776832, "containerizer/mesos/docker_store/pull_ms/min": 3167.337984, "containerizer/mesos/docker_store/pull_ms/p95": 12091.4106496, "containerizer/mesos/docker_store/pull_ms/p99": 12441.62789632, "containerizer/mesos/docker_store/layers": 47, ``` Thanks, Zhitao Li