----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53450/#review154980 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/mesos.proto (line 2115) <https://reviews.apache.org/r/53450/#comment224796> I see you changed s/TtyInfo/TTYInfo/ Is this intentional? I know @bmahler has lamented in the past about decisions like this. (e.g. `HTTPScheduler` he would prefer to be `HttpScheduler`). - Kevin Klues On Nov. 4, 2016, 12:35 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53450/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 12:35 a.m.) > > > Review request for mesos, Anand Mazumdar, Benjamin Mahler, Jie Yu, and Kevin > Klues. > > > Bugs: MESOS-6525 > https://issues.apache.org/jira/browse/MESOS-6525 > > > Repository: mesos > > > Description > ------- > > Added to ContainerInfo because we want to be able to attach to > containers that are launched without a CommandInfo. > > > Diffs > ----- > > include/mesos/mesos.proto 905a34bb13c2fcd1b22ef4e9605405ef84711c25 > include/mesos/v1/mesos.proto b72069a6caff0b163d9d9cae45c3caa0b25de38f > > Diff: https://reviews.apache.org/r/53450/diff/ > > > Testing > ------- > > make > > > Thanks, > > Vinod Kone > >
