> On Nov. 2, 2016, 9:54 a.m., Benjamin Bannier wrote: > > 3rdparty/stout/tests/json_tests.cpp, line 175 > > <https://reviews.apache.org/r/52886/diff/2/?file=1547700#file1547700line175> > > > > Not yours, but the ordering of parameters (should be `expected, > > actual`) is wrong here and in many other places in this file. > > > > It would be great if you could submit a separate cleanup patch for that. > > Neil Conway wrote: > FWIW, the next version of gtest changes this to treat the lhs and rhs of > an expectation equivalently > (https://github.com/google/googletest/commit/f364e188372e489230ef4e44e1aec6bcb08f3acf).
We okay with dropping this then? - Aaron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52886/#review154529 ----------------------------------------------------------- On Oct. 27, 2016, 7:32 p.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52886/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2016, 7:32 p.m.) > > > Review request for mesos, James Peach, Michael Park, and Neil Conway. > > > Bugs: MESOS-6239 > https://issues.apache.org/jira/browse/MESOS-6239 > > > Repository: mesos > > > Description > ------- > > The hardening flags produced many new sign comparison errors in stout that > need to be fixed for Mesos to compile/run. > > > Diffs > ----- > > 3rdparty/stout/tests/cache_tests.cpp 0950c85 > 3rdparty/stout/tests/flags_tests.cpp da4deb9 > 3rdparty/stout/tests/hashmap_tests.cpp 2626d67 > 3rdparty/stout/tests/hashset_tests.cpp 66e59db > 3rdparty/stout/tests/ip_tests.cpp b5a206f > 3rdparty/stout/tests/json_tests.cpp 2bc4c88 > 3rdparty/stout/tests/linkedhashmap_tests.cpp 7a80769 > 3rdparty/stout/tests/multimap_tests.cpp 488991b > 3rdparty/stout/tests/os/process_tests.cpp 4cb3b5f > 3rdparty/stout/tests/os/sendfile_tests.cpp e221689 > 3rdparty/stout/tests/os/systems_tests.cpp 110ba5b > 3rdparty/stout/tests/os_tests.cpp 0b7ee07 > 3rdparty/stout/tests/strings_tests.cpp 7dd3301 > > Diff: https://reviews.apache.org/r/52886/diff/ > > > Testing > ------- > > Made sure compilation, tests, and benchmarks worked with both gcc and clang. > Ran make && make check && make bench. > > > Thanks, > > Aaron Wood > >
