> On Oct. 31, 2016, 2:20 p.m., Joseph Wu wrote: > > src/local/local.cpp, lines 214-228 > > <https://reviews.apache.org/r/53313/diff/1/?file=1549317#file1549317line214> > > > > If you move `#ifdef` up one, you won't need to add the extra `EXIT(..)`. > > Alex Clemmer wrote: > I personally would rather have an exit message that specifically tells > the user about their invalid configuration. Do you think that this is a bad > idea?
You'd fall through to this error message: ``` "'" << masterFlags.registry << "' is not a supported option for registry persistence"; ``` I'd say this message is pretty much the same as the message you've added. The `on Windows` part should hopefully be pretty obvious to the user :) - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53313/#review154320 ----------------------------------------------------------- On Nov. 7, 2016, 10:23 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53313/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2016, 10:23 a.m.) > > > Review request for mesos, Daniel Pravat and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Many agent tests currently use the master in some form. Of those, > relatively few use the leveldb-based persistence. Since we cannot > currently compile leveldb on Windows, and since running these tests on > Windows involves compiling and running the master, this commit will > remove the direct dependency on the replicated log for windows builds of > the master. > > > Diffs > ----- > > src/local/local.cpp 257179443827ffdfc946ed655a6840fcea70d454 > src/master/main.cpp 2d2dfb7d632f3c7be1796efd8f0a1f4d18760261 > > Diff: https://reviews.apache.org/r/53313/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
