> On Nov. 7, 2016, 10:51 p.m., Jie Yu wrote: > > Looks like the review bot has a segfault?
The failed test 'HTTPCommandExecutorTest.TerminateWithACK' is broken on master head so it's not it. I saw Anand pinging Qian on the build mailing list. We can have a JIRA to track it. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53500/#review155266 ----------------------------------------------------------- On Nov. 7, 2016, 12:13 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53500/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2016, 12:13 p.m.) > > > Review request for mesos, Anindya Sinha, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-6526 > https://issues.apache.org/jira/browse/MESOS-6526 > > > Repository: mesos > > > Description > ------- > > Used an environment variable to pass command environment. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 67cc595278f124cdf518d2f4fcfb257439f067e2 > src/slave/containerizer/mesos/main.cpp > 1a0e765ddb6d8519426b8d47067efdfa3432e07a > > Diff: https://reviews.apache.org/r/53500/diff/ > > > Testing > ------- > > make check. > > No new tests are written but the fact the existing tests that run exectuors > depends on this to work correctly is a proof. > > > Thanks, > > Jiang Yan Xu > >
