----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53351/#review155549 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Nov. 4, 2016, 9:32 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53351/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 9:32 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6464 > https://issues.apache.org/jira/browse/MESOS-6464 > > > Repository: mesos > > > Description > ------- > > A 'ContainerClass' must now be passed to all *nested* > containerizer->launch() calls in order to specify the class of > container being launched. For now, we simply have the default nested > container class (called 'NESTED') in a subsequent commit we will > introduce the 'DEBUG' class to help classify debug-based nested > containers that should be launched slightly differently than default > nested containers. > > The 'ContainerClass' specified is passed through to each isolator in > 'ContainerConfig' so they have a chance to custiomize their isolation > policies based on the class as well. > > > Diffs > ----- > > include/mesos/slave/containerizer.proto > f4c4ad771b5dead4ea3ee7cd1b4383c4dc2359b4 > src/slave/containerizer/composing.hpp > 68c0523bb96e1078bd95c6094bce04c38c2fc9dd > src/slave/containerizer/composing.cpp > 0c5489f8dffaf75bce26a042000eaf7376f05ff4 > src/slave/containerizer/containerizer.hpp > 7554446ac51a9063bd52b8b99845c73650740849 > src/slave/containerizer/mesos/containerizer.hpp > c4fea8b56c39d5a363f6ea80bd109fd2d3db52d9 > src/slave/containerizer/mesos/containerizer.cpp > 67cc595278f124cdf518d2f4fcfb257439f067e2 > src/slave/http.cpp a32aca437cffd52bc2bcde859eedddca2038e3f1 > src/tests/api_tests.cpp 57981f12d429614a537733ac4cec9c0e72ff6d6f > src/tests/containerizer.hpp 080b8fa695d4c0dd2ed2bf028f1fc617dad23943 > src/tests/containerizer.cpp c3bcb85d245a0e95b377059802cd89617eb5e25c > > Diff: https://reviews.apache.org/r/53351/diff/ > > > Testing > ------- > > make -j check > > > Thanks, > > Kevin Klues > >
