> On Nov. 11, 2016, 12:01 a.m., Avinash sridharan wrote: > > src/cli/execute.cpp, line 1065 > > <https://reviews.apache.org/r/53645/diff/1/?file=1560396#file1560396line1065> > > > > Instead of this why can't we just do: > > > > Option<TaskInfo> taskInfo = flags.task > > > > if (flags.task.isNone() && flags.task_group.isNone()) { > > .... > > } > > > > This would be more explicit than using flags.name.isSome() for implying > > the above condition.
Yes, we can do it, thanks for the comments! - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53645/#review155598 ----------------------------------------------------------- On Nov. 10, 2016, 9:44 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53645/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2016, 9:44 p.m.) > > > Review request for mesos, Avinash sridharan, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-6571 > https://issues.apache.org/jira/browse/MESOS-6571 > > > Repository: mesos > > > Description > ------- > > Added '--task' into mesos-execute. > > > Diffs > ----- > > src/cli/execute.cpp b47c427c5ad29dda1985ee8fef6c4efe054df879 > > Diff: https://reviews.apache.org/r/53645/diff/ > > > Testing > ------- > > On Ubuntu 16.04, manually ran the command below to successfuly launch a > container which will be attached to a CNI network "net1". > ``` > # sudo src/mesos-execute --master=192.168.122.216:5050 > --task=file:///home/stack/workspace/mesos/build/task.json > > # cat /home/stack/workspace/mesos/build/task.json > { > "name": "test", > "task_id": {"value" : "test"}, > "agent_id": {"value" : ""}, > "resources": [ > { > "name": "cpus", > "type": "SCALAR", > "scalar": { > "value": 0.1 > }, > "role": "*" > }, > { > "name": "mem", > "type": "SCALAR", > "scalar": { > "value": 32 > }, > "role": "*" > } > ], > "command": { > "value": "ifconfig" > }, > "container": { > "type": "MESOS", > "mesos": { > "image": { > "type": "DOCKER", > "docker": { > "name": "busybox" > } > } > }, > "network_infos": [ > { > "name": "net1" > } > ] > } > } > ``` > > > Thanks, > > Qian Zhang > >