----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53490/#review155743 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/src/tests/http_tests.cpp (lines 1249 - 1250) <https://reviews.apache.org/r/53490/#comment225820> Hm.. might be helpful to indicate that we test that the server correctly receives the uncompressed data from the request. That is, we're testing the server side here more so than the http::Connection side, so I would have expected this to be an HTTPTest rather than an HTTPConnection test, as in this test the http::Connection isn't doing anything related to gzip, right? With this in mind, feel free to move it to an HTTPTest. 3rdparty/libprocess/src/tests/http_tests.cpp (line 1251) <https://reviews.apache.org/r/53490/#comment225818> How about HTTPConnectionTest.GzipRequestBody since there can be gzip response bodies. As far as I know, gzip is not an acryonym, the G stands for GNU but zip itself isn't an acryonym, if this is the case then no need to do ALLCAPS. - Benjamin Mahler On Nov. 11, 2016, 7:57 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53490/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2016, 7:57 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-6466 > https://issues.apache.org/jira/browse/MESOS-6466 > > > Repository: mesos > > > Description > ------- > > These tests validate that clients can stream requests and send > compressed GZIP requests using the connection abstraction. This > also test the implementation of the streaming decoder indirectly. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/http_tests.cpp > 533104c93dd1eaf67bf3752163d2e0cad090078d > > Diff: https://reviews.apache.org/r/53490/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
