----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53754/#review156212 -----------------------------------------------------------
src/examples/CMakeLists.txt (line 24) <https://reviews.apache.org/r/53754/#comment226375> In the other blocks we seem to put this one first. Maybe consider putting it first here, too? - Alex Clemmer On Nov. 15, 2016, 3:08 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53754/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2016, 3:08 a.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > Builds shared libraries that are dynamically loaded in the > module tests. These are excluded on Windows, which only > supports static libraries. > > This review replaces: https://reviews.apache.org/r/49863/ > > > Diffs > ----- > > CMakeLists.txt 1362d65afc23816c34173866a3fdbce45936921d > cmake/MesosConfigure.cmake de04389b016b22bdff69e94d37fad4eedbda5874 > src/CMakeLists.txt aef9ae6d2872dc15725c01ce85b657965485605f > src/examples/CMakeLists.txt PRE-CREATION > src/examples/cmake/ExamplesConfigure.cmake PRE-CREATION > > Diff: https://reviews.apache.org/r/53754/diff/ > > > Testing > ------- > > cmake .. > make > > > Thanks, > > Joseph Wu > >
