----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53756/#review156217 -----------------------------------------------------------
src/slave/container_loggers/CMakeLists.txt (line 25) <https://reviews.apache.org/r/53756/#comment226381> For my own education, this must be shared, rather than `MESOS_DEFAULT_LIBRARY_LINKAGE`? Or am I misunderstanding? src/slave/container_loggers/CMakeLists.txt (line 30) <https://reviews.apache.org/r/53756/#comment226382> Seems like it might be easier to just `if` out the line that includes this `CMakeLists.txt`? - Alex Clemmer On Nov. 15, 2016, 10:56 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53756/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2016, 10:56 p.m.) > > > Review request for mesos, Alex Clemmer and Joris Van Remoortere. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > This review replaces: https://reviews.apache.org/r/49874/ > > > Diffs > ----- > > src/slave/CMakeLists.txt 33120ace79bce449329a7cc4b7ef264d2867fc13 > src/slave/cmake/SlaveConfigure.cmake > b339239761a5de321d65b92376dae69c339bee5c > src/slave/container_loggers/CMakeLists.txt PRE-CREATION > > Diff: https://reviews.apache.org/r/53756/diff/ > > > Testing > ------- > > cmake .. > make > > > Thanks, > > Joseph Wu > >
