----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52647/ -----------------------------------------------------------
(Updated Nov. 18, 2016, 4:24 p.m.) Review request for mesos, James Peach, Michael Park, and Neil Conway. Changes ------- Addressed comments and made a few small fixes. Bugs: MESOS-6239 https://issues.apache.org/jira/browse/MESOS-6239 Repository: mesos Description ------- The hardening flags produced many new sign comparison errors in libprocess that need to be fixed for Mesos to compile/run. Diffs (updated) ----- 3rdparty/libprocess/src/decoder.hpp 76dca0b 3rdparty/libprocess/src/encoder.hpp 005d1cc 3rdparty/libprocess/src/process.cpp ab2b5a9 3rdparty/libprocess/src/tests/decoder_tests.cpp 4535614 3rdparty/libprocess/src/tests/encoder_tests.cpp 9e57375 3rdparty/libprocess/src/tests/http_tests.cpp 533104c 3rdparty/libprocess/src/tests/io_tests.cpp b85c79f 3rdparty/libprocess/src/tests/subprocess_tests.cpp 0dc1c62 Diff: https://reviews.apache.org/r/52647/diff/ Testing ------- Made sure compilation, tests, and benchmarks worked with both gcc and clang. Ran `make && make check && make bench`. Thanks, Aaron Wood