> On Nov. 18, 2016, 1:24 a.m., Jiang Yan Xu wrote: > > src/tests/containerizer/rootfs.cpp, lines 81-84 > > <https://reviews.apache.org/r/53791/diff/2/?file=1564519#file1564519line81> > > > > If we have to do this, format it this way > > > > ``` > > auto entry = std::find_if( > > cache.begin(), > > cache.end(), > > [dependency](const ldcache::Entry& e) { > > return strings::startsWith(e.name, dependency); > > }); > > ``` > > > > But is prefix matching necessary? Can't we do extract matching > > (i.e.,`hashset.contains()`)? > > > > Note that our seed list are just programs without versions.
I checked that you don't need the `startsWith`. The ld cache is a vector so I still need to do the linear search. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review156259 ----------------------------------------------------------- On Nov. 18, 2016, 7:23 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53791/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2016, 7:23 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Kevin Klues, and Jiang Yan Xu. > > > Bugs: MESOS-6588 > https://issues.apache.org/jira/browse/MESOS-6588 > > > Repository: mesos > > > Description > ------- > > The dependencies for the programs we need in the Linux root > filesystem vary over time and across distributions. Since Stout > has support for parsing the library dependencies of ELF binaries, > use this to collect the necessary dependencies when constructing > a root filesystem for the tests. > > > Diffs > ----- > > src/tests/containerizer/rootfs.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/53791/diff/ > > > Testing > ------- > > sudo make check (Fedora 24) > > > Thanks, > > James Peach > >
