> On Nov. 23, 2016, 1:27 p.m., Gastón Kleiman wrote: > > src/hook/manager.cpp, line 385 > > <https://reviews.apache.org/r/54019/diff/1/?file=1568981#file1568981line385> > > > > s/Resources/Attributes/
Thanks, good catch! - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54019/#review156729 ----------------------------------------------------------- On Nov. 23, 2016, 2:19 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54019/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2016, 2:19 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-6626 > https://issues.apache.org/jira/browse/MESOS-6626 > > > Repository: mesos > > > Description > ------- > > Various places were doing `foreach` over the output of > `LinkedHashMap::keys()` or `LinkedHashMap::values()`; this can be > replaced with `foreachkey` and `foreachvalue`, respectively. > > > Diffs > ----- > > src/examples/long_lived_executor.cpp > 5c43ee780997c105e4f3dd6081d4c5418bef7ab6 > src/examples/test_http_executor.cpp > b9b6bfdc55dead5b70d40b4389e65a2194babc0e > src/exec/exec.cpp 1dc20390907253a466b7272b7f8b33ea14afb236 > src/hook/manager.cpp 24885226a788a7abd851e12b527f74fa972ec935 > src/launcher/default_executor.cpp f4e1ea4816fee9a2f6d59bb534933b66013f11cf > src/launcher/executor.cpp ce0b199551447504bb95743df4ce9ec4a0443cd4 > src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a > src/slave/http.cpp aa9f492fc74283b5a6f24a8b7189f1ecbe41488f > src/slave/slave.cpp 521f08d59cd78f9089d58cd3294f0ee4a099cd7f > > Diff: https://reviews.apache.org/r/54019/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
