----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54038/#review156918 -----------------------------------------------------------
Fix it, then Ship it! Just a few typos, but it looks good to me =). include/mesos/hook.hpp (line 111) <https://reviews.apache.org/r/54038/#comment227279> s/superceded/superseded/ include/mesos/hook.hpp (line 149) <https://reviews.apache.org/r/54038/#comment227280> s/mappe/mapped/ include/mesos/hook.hpp (line 159) <https://reviews.apache.org/r/54038/#comment227282> ditto typo - Gastón Kleiman On Nov. 25, 2016, 4:10 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54038/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2016, 4:10 a.m.) > > > Review request for mesos, Adam B, Gastón Kleiman, Kapil Arya, and Joseph Wu. > > > Bugs: MESOS-6396 > https://issues.apache.org/jira/browse/MESOS-6396 > > > Repository: mesos > > > Description > ------- > > For being able to supply environment additions for both, a task and > its executor separately we need to introduce a new hook as the > existing ones slavePreLaunchDockerHook (deprecated) as well as > slavePreLaunchDockerEnvironmentDecorator do not allow for this. > > This new hook will likely allow for further additions like e.g. > adding volumes without having to adapt the signature but only the > returned proto message TaskExecutorDecoratorInfo. > > > Diffs > ----- > > include/mesos/hook.hpp f0606e3a68fa179cf7ea036f10563ef47c2aefa7 > include/mesos/module/hook.proto PRE-CREATION > src/Makefile.am 5e0b8406f7f624bd8b03ff76b887f20e22fc66e0 > src/hook/manager.hpp 5ecfcab48da808c84d36f9bcfcb5a8e0ad2167e5 > src/hook/manager.cpp 24885226a788a7abd851e12b527f74fa972ec935 > src/slave/containerizer/docker.cpp ccabf99f305d7874e1c46bc618ea74341eb281ef > > Diff: https://reviews.apache.org/r/54038/diff/ > > > Testing > ------- > > make check > > *WIP - functional test pending - unit tests pending - WIP* > > > Thanks, > > Till Toenshoff > >
