> On Nov. 25, 2016, 3:09 p.m., haosdent huang wrote: > > src/tests/health_check_tests.cpp, line 842 > > <https://reviews.apache.org/r/46307/diff/5/?file=1570532#file1570532line842> > > > > Change here to make it consistent with > > > > ``` > > // This test creates a task whose health flaps, and verifies that the > > // health status updates are sent to the framework. > > > > TEST_F(HealthCheckTest, HealthStatusChange) > > ```
Framework scheduler is probably the best name : ) - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46307/#review156922 ----------------------------------------------------------- On Nov. 25, 2016, 3:08 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46307/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2016, 3:08 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Greg Mann, > Neil Conway, and Timothy Chen. > > > Bugs: MESOS-1802 > https://issues.apache.org/jira/browse/MESOS-1802 > > > Repository: mesos > > > Description > ------- > > In HealthStatusChange test cases, we launch a task that toggles between > healthy and unhealthy, and will never be killed because no consecutive > health failures occur. We need to ignore subsequent status updates: it > is possible to continue to receive status updates before we stop the > driver. > > > Diffs > ----- > > src/tests/health_check_tests.cpp a4436bdb70ca988106742dadb0762c99a4ebe369 > > Diff: https://reviews.apache.org/r/46307/diff/ > > > Testing > ------- > > # I still could not reproduce the problem in old code after repeatedly tests. > So seems no way to verify whether my assumption is correct or not. > > > Thanks, > > haosdent huang > >
