-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54077/#review156930
-----------------------------------------------------------



Thanks for the cleanup. Can you do a sweep in this file and fix the other 
decoders to correctly initialize the `settings` variable too?

- Anand Mazumdar


On Nov. 25, 2016, 11:41 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54077/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2016, 11:41 a.m.)
> 
> 
> Review request for mesos and Anand Mazumdar.
> 
> 
> Bugs: MESOS-6646
>     https://issues.apache.org/jira/browse/MESOS-6646
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made sure parser settings member is properly initialized.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/decoder.hpp 
> 13db2eeea6f4b564c970c0cddcdebbe789aba65d 
> 
> Diff: https://reviews.apache.org/r/54077/diff/
> 
> 
> Testing
> -------
> 
> `make check` (OS X, clang trunk w/o optimizations, SSL build)
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to