----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54081/ -----------------------------------------------------------
(Updated Nov. 28, 2016, 12:15 p.m.) Review request for mesos, Benjamin Mahler and Vinod Kone. Changes ------- Added source file to `src/CMakeLists.txt`. Bugs: MESOS-1648 https://issues.apache.org/jira/browse/MESOS-1648 Repository: mesos Description (updated) ------- Added `--pidfile` option to master and agent binaries. Diffs (updated) ----- src/CMakeLists.txt d6e213686a44fbca0ed841594ce803151224a5a7 src/Makefile.am dd1626d177b38a6613f18f32bb0668abbb5100e0 src/common/pid_file.hpp PRE-CREATION src/common/pid_file.cpp PRE-CREATION src/logging/logging.cpp 70d66a5c396f709e8f27ad0d51315ed6d257f73b src/master/main.cpp fa7ba1310142a3bef71379ba37fded9b8390aae9 src/slave/main.cpp 8010f8e229e2d820649750c9db0456ecd1b854d3 src/tests/common/pid_file_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/54081/diff/ Testing ------- Added test to verify that PID file is created upon `PIDFile` object creation and deleted upon its destruction. Ran `make check`. Thanks, Ilya Pronin