> On Dec. 2, 2016, 8:19 a.m., Qian Zhang wrote: > > src/master/master.cpp, line 2373 > > <https://reviews.apache.org/r/54062/diff/6/?file=1572829#file1572829line2373> > > > > I think you can merge the logic of `isValidFailoverTimeout()` into the > > method `validation::framework::validate()` which should be the central > > place to validate `FrameworkInfo`, and then we do not need > > `isValidFailoverTimeout()` anymore. > > Jay Guo wrote: > Yes and also I think all FrameworkInfo validation logic in that context > could go to a seperate method in order to be reused by both `subscribe()`
Will do follow up patch to merge `isValidFailoverTimeout` into `framework::validate` as Qian suggested here. - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/#review157712 ----------------------------------------------------------- On Dec. 2, 2016, 8:44 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54062/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2016, 8:44 a.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, and Qiang Zhang. > > > Bugs: MESOS-6629 > https://issues.apache.org/jira/browse/MESOS-6629 > > > Repository: mesos > > > Description > ------- > > Roles should not contain duplicate entries. Also, we need to validate > that 'role', 'roles' and MULTI_ROLE capability are set properly. They > are checked against following matrix: > > -- MULTI_ROLE is NOT set -- > +-------+-------+---------+ > | |Roles |No Roles | > +-------+-------+---------+ > |Role | Error | None | > +-------+-------+---------+ > |No Role| Error | None | > +-------+-------+---------+ > > ---- MULTI_ROLE is set ---- > +-------+-------+---------+ > | |Roles |No Roles | > +-------+-------+---------+ > |Role | Error | Error | > +-------+-------+---------+ > |No Role| None | None | > +-------+-------+---------+ > > > Diffs > ----- > > src/master/validation.hpp b8389460f34b3531f2b6ff93f18f496c01e1a079 > src/master/validation.cpp 42d9b4a8784c2a161b74d7b46619cc22272e14e3 > > Diff: https://reviews.apache.org/r/54062/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jay Guo > >
