----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54291/#review157948 -----------------------------------------------------------
Ship it! Adding the TODO for `ptsname_r` on Linux SGTM as well as using `const char*` if possible. Otherwise LGTM. - Benjamin Hindman On Dec. 2, 2016, 6:29 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54291/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2016, 6:29 p.m.) > > > Review request for mesos, Benjamin Hindman and Kevin Klues. > > > Bugs: MESOS-6470 > https://issues.apache.org/jira/browse/MESOS-6470 > > > Repository: mesos > > > Description > ------- > > Added os::ptsname to stout. > > > Diffs > ----- > > 3rdparty/stout/include/stout/posix/os.hpp > c37e64db662ba3cee83d2f55de0f9d71ad72c038 > > Diff: https://reviews.apache.org/r/54291/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
