----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54134/#review158024 -----------------------------------------------------------
Ship it! Can you also do a sweep in `src/tests/slave_tests.cpp` for other task group related tests that have a similar wrong assumption? I would go ahead and commit this for now. - Anand Mazumdar On Nov. 28, 2016, 6:32 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54134/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2016, 6:32 p.m.) > > > Review request for mesos and Anand Mazumdar. > > > Repository: mesos > > > Description > ------- > > Just like TASK_KILLED updates, TASK_RUNNING updates can arrive in any > order. Adjust the code to not assume a particual order. > > Also cleaned up the code to minimize the mutated state. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > 5bddcc3d21523a83301a7c410e8f96dbd8e8e104 > > Diff: https://reviews.apache.org/r/54134/diff/ > > > Testing > ------- > > * `make check` (OS X), internal CI on various Linux configurations. > * also tested with `*DefaultExecutor*` tests selected. > > > Thanks, > > Benjamin Bannier > >
