----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54352/#review158033 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/io/switchboard.cpp (line 539) <https://reviews.apache.org/r/54352/#comment228697> We should not capture 'this' without a defer. Either use a 'defer' here, or capture `flags.runtime_dir`. - Jie Yu On Dec. 5, 2016, 7:10 a.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54352/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2016, 7:10 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6689 > https://issues.apache.org/jira/browse/MESOS-6689 > > > Repository: mesos > > > Description > ------- > > Added removal of unix domain socket path in IOSwitchboard::cleanup. > > > Diffs > ----- > > src/slave/containerizer/mesos/io/switchboard.cpp > d5211b98616e72a27ca6b472a5ee83505c227f22 > > Diff: https://reviews.apache.org/r/54352/diff/ > > > Testing > ------- > > GTEST_FILTER="" make -j check > sudo src/mesos-tests > > > Thanks, > > Kevin Klues > >
