----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54408/#review158316 -----------------------------------------------------------
Patch looks great! Reviews applied: [53885, 53886, 53887, 53888, 53889, 53890, 53891, 53892, 53893, 53894, 53895, 53896, 53897, 54467, 54468, 54380, 54387, 54177, 54178, 54179, 54180, 54181, 54182, 54183, 54232, 54312, 54407, 54408] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Dec. 7, 2016, 4:20 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54408/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2016, 4:20 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6719 > https://issues.apache.org/jira/browse/MESOS-6719 > > > Repository: mesos > > > Description > ------- > > That is, the master previously tracked two separate things about a > framework: its "state" (CONNECTED, DISCONNECTED, or RECOVERED), and > whether the framework is considered active. It is simpler to represent > the latter value as just another state: a framework can now be ACTIVE, > INACTIVE, DISCONNECTED, or RECOVERED. A framework is "connected" if it > is either ACTIVE or INACTIVE. This rules out a few combinations that > never made sense, such as "state = DISCONNECTED and active = TRUE". > > > Diffs > ----- > > src/master/http.cpp ac560d1fdd219d0de0c5d987a32a7112e149602f > src/master/master.hpp b444b2352360fb4f7179acd97dffc0cd81cc7afa > src/master/master.cpp b0670d993348d189fafff0f83f9da0c5b18d1c51 > src/master/quota_handler.cpp 5578663f26d9b737499dc4f5a286c34c37645442 > > Diff: https://reviews.apache.org/r/54408/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
