> On Dec. 7, 2016, 1:26 a.m., Adam B wrote: > > src/slave/http.cpp, line 2398 > > <https://reviews.apache.org/r/54381/diff/1-2/?file=1576455#file1576455line2398> > > > > Nit: You use this value 3 times. Maybe worth pulling it out into a > > variable.
There is a reason, `has_container_id()` is used once, and `container_id()` twice, but each in different execution contexts, once in `attachContainerInput` and a second one in the callback lambda. I thought leaving it in the `call` object would reduce the ammount of unncesesary copying. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54381/#review158255 ----------------------------------------------------------- On Dec. 6, 2016, 3:15 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54381/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2016, 3:15 p.m.) > > > Review request for mesos, Adam B, Kevin Klues, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Introduces authorization support for the newly introduced debug API > calls: `AttachContainerInput` and `AttachContainerOutput`. > > > Diffs > ----- > > src/slave/http.cpp 91eebe117d3dc86dd5b1fd47156c01e147165cef > src/slave/slave.hpp 4b94dff9c1f9f212f84984674268ef38b43d93bd > src/slave/slave.cpp 7eb45036f49289972c0b706c3c8e2ed96553d279 > src/tests/api_tests.cpp 7c70f284a9225ca23abc7049f48f3efba314b641 > > Diff: https://reviews.apache.org/r/54381/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
