----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53299/#review158898 -----------------------------------------------------------
3rdparty/libprocess/include/process/future.hpp (line 1307) <https://reviews.apache.org/r/53299/#comment229718> Same rename suggestion as below. 3rdparty/libprocess/include/process/future.hpp (line 1321) <https://reviews.apache.org/r/53299/#comment229719> Can you explain why we're adding this behavior with a comment? It's not immediately clear to me from the existing code / comment what the implication is of making this association if the weak future is `none`. 3rdparty/libprocess/include/process/future.hpp (line 1417) <https://reviews.apache.org/r/53299/#comment229717> Consider renaming `reference` to `weak_future`. The reference could no longer be valid, which is why I think the name might be deceptive (even though the type is clear). 3rdparty/libprocess/src/tests/future_tests.cpp (line 266) <https://reviews.apache.org/r/53299/#comment229714> What does the word 'policy' here denote? Could you pick something more consistent with the other tests? 3rdparty/libprocess/src/tests/future_tests.cpp (line 268) <https://reviews.apache.org/r/53299/#comment229715> Can you provide context for the scoped block? e.g. ``` /* Future lifetime. */ { } ``` 3rdparty/libprocess/src/tests/future_tests.cpp (lines 270 - 273) <https://reviews.apache.org/r/53299/#comment229716> I think your indentation here is off. 4 spaces for function arguments. - Joris Van Remoortere On Oct. 31, 2016, 2:48 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53299/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2016, 2:48 p.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Joris Van Remoortere. > > > Bugs: MESOS-6484 > https://issues.apache.org/jira/browse/MESOS-6484 > > > Repository: mesos > > > Description > ------- > > Removes a reference counted pointer that futures kept to themselves > when using the method `Future<T>::after()`. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > 175214a9090f8cc8241a81e535c87370102f3011 > 3rdparty/libprocess/src/tests/future_tests.cpp > 7c411c7be1849119fe0b070622dbe4488fa11b7a > > Diff: https://reviews.apache.org/r/53299/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Alexander Rojas > >
