> On Dec. 13, 2016, 10:44 a.m., Adam B wrote: > > src/slave/http.cpp, line 766 > > <https://reviews.apache.org/r/54661/diff/1/?file=1581994#file1581994line766> > > > > Is the plan to move everything over to the ObjectApprover API? > > I notice that the v0 /flags endpoint just calls > > `slave->authorizer.get()->authorized(authRequest)` > > Should we update it too?
That has, indeed, been the plan since the introduction of the object approver concept. Though my original plan was to do a sweep clean of all the places where the `Authorizer::authorized()` calls exist. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54661/#review158973 ----------------------------------------------------------- On Dec. 13, 2016, 3:49 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54661/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 3:49 p.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-6670 > https://issues.apache.org/jira/browse/MESOS-6670 > > > Repository: mesos > > > Description > ------- > > Adds the stub which allows for restriction of users when attempting > to access the `GET_FLAGS` API v1 call. > > > Diffs > ----- > > src/slave/http.cpp 8a71eadd8f26df147ddea800221b6f243280bf3b > > Diff: https://reviews.apache.org/r/54661/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >