----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54896/#review159839 -----------------------------------------------------------
Ship it! Ship It! - James Peach On Dec. 21, 2016, 11:20 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54896/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2016, 11:20 a.m.) > > > Review request for mesos, James Peach and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > This target was `PHONY`, but not declared as such. It also explicitly > used `ln` with a `--force` flag instead of the more generally > applicable and suggested `$(LN_S)` we use elsewhere, and was > inconsistent on whether content was linked or copied. > > This change fixes above issues. We also use independent shell commands > for independent commands and fix some whitespace issues. > > > Diffs > ----- > > src/Makefile.am abcf7eed717ccd2396540011d7fb9fc7959c18f2 > > Diff: https://reviews.apache.org/r/54896/diff/ > > > Testing > ------- > > `make distcheck` (Fedora 25) > > > Thanks, > > Benjamin Bannier > >
