> On Dec. 21, 2016, 11:40 p.m., Zhitao Li wrote: > > include/mesos/mesos.proto, lines 1107-1108 > > <https://reviews.apache.org/r/54693/diff/2-3/?file=1590188#file1590188line1107> > > > > Why is this newly added field in the middle of the message rather than > > the end?
Make sense now since I just renamed the `blkio` field to a more generic field named `cgroups`. The initial placement was in purpose of putting `blkio` closer to `disk_*` fields. I'll address this altogether after @jieyu's comment. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54693/#review159876 ----------------------------------------------------------- On Dec. 21, 2016, 8:06 p.m., Jason Lai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54693/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2016, 8:06 p.m.) > > > Review request for mesos, Xiaojian Huang, Gilbert Song, haosdent huang, Jie > Yu, Kunal Thakar, and Zhitao Li. > > > Bugs: MESOS-6162 > https://issues.apache.org/jira/browse/MESOS-6162 > > > Repository: mesos > > > Description > ------- > > Add ProtoBuf schema for Blkio cgroups per the kernel Blkio controller doc. > > > Diffs > ----- > > include/mesos/mesos.proto 0017d3d9d46433b391703025f611ce437bbc7ebe > > Diff: https://reviews.apache.org/r/54693/diff/ > > > Testing > ------- > > > Thanks, > > Jason Lai > >
