----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55023/#review160115 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp (line 1611) <https://reviews.apache.org/r/55023/#comment231120> This code was working before. you should not change it to make the taest work and add overhead in production. - Daniel Pravat On Dec. 24, 2016, 10:02 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55023/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2016, 10:02 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, > and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Currently in `MesosContainerizerProcess::_launch`, we are passing a > malformatted shell command to the launcher. This causes the > containerizer process to crash immediately upon invocation in all > executor tests. > > This commit will fix this command. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > d9d5619e45ae1199fc91878f17a33b5647f48305 > > Diff: https://reviews.apache.org/r/55023/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >