----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54232/#review160439 -----------------------------------------------------------
src/master/master.cpp (line 5512) <https://reviews.apache.org/r/54232/#comment231583> inline this? src/tests/partition_tests.cpp (lines 1130 - 1133) <https://reviews.apache.org/r/54232/#comment231585> I agree. Lets move unreachable tasks to completed as well in `removeFramework` to avoid confusion. We can change the behavior for PA and non-PA together at a later time if necessary. - Vinod Kone On Dec. 2, 2016, 12:25 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54232/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2016, 12:25 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6602 > https://issues.apache.org/jira/browse/MESOS-6602 > > > Repository: mesos > > > Description > ------- > > Previously, if a framework completed (e.g., due to a teardown operation > or framework shutdown), any framework tasks running on partitioned > agents would not be shutdown when the agent re-registered. For tasks > that are not partition-aware, the task would be shutdown on agent > re-registration anyway. But for partition-aware tasks, this could lead > to orphan tasks. > > Fix this by changing the master to shutdown such tasks when the agent > reregisters. > > Note that if the master fails over between the time the framework > completes and a partitioned agent re-registers, any framework tasks > running on the agent will NOT be shutdown. This is a known bug; fixing > it requires persisting the framework shutdown operation to the registry > (MESOS-1719). > > > Diffs > ----- > > src/master/master.hpp 877ca9010d0d6efc97f3d71fbd27272a255409d0 > src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a > src/tests/partition_tests.cpp 5a0d4bd2de6a5aa0e9fdf0d34cd10d16fd4e34a1 > > Diff: https://reviews.apache.org/r/54232/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
