----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50871/#review160442 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/paths.cpp (line 65) <https://reviews.apache.org/r/50871/#comment231587> Backend no longer needed to be recorded when it's auto selected? src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 294) <https://reviews.apache.org/r/50871/#comment231586> Remove this - Timothy Chen On Jan. 3, 2017, 10:47 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50871/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2017, 10:47 p.m.) > > > Review request for mesos, Avinash sridharan, Artem Harutyunyan, Jie Yu, and > Timothy Chen. > > > Bugs: MESOS-5931 > https://issues.apache.org/jira/browse/MESOS-5931 > > > Repository: mesos > > > Description > ------- > > Select a backend smartly. Currently, the logic is really > simple: > 1. Use overlayfs backend if it exists. > 2. Use aufs backend if the overlayfs does not exists. > 3. Use copy backend of both overlayfs and aufs do not exist. > Please note that the bind backend needs to be specified explicitly > through the agent flag '--image_provisioner_backend' since it > requires the sandbox already existed. > > > Diffs > ----- > > docs/configuration.md e4beb2d5a72f1c5f59b2e40f4984cc60b8437d9d > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp > 817e30c5d6d6a4b011193e3209301fc3cdf88b06 > src/slave/containerizer/mesos/provisioner/docker/paths.hpp > 232c027f8f96da0cb30b957bce4607d3695050d2 > src/slave/containerizer/mesos/provisioner/docker/paths.cpp > cd684b33eb308ce1eeb4539a5b2d51985d835db7 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > b06ddff68a8d2df13abb838b03a8e73d4e273c31 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 9dccd0673dbc0c61abfd4b88097f86e7d7131c46 > src/slave/containerizer/mesos/provisioner/provisioner.cpp > db2d267996959453f9896287320dca37440b499b > src/slave/flags.hpp 6ac0d45072157f6741b96266886a326e9337c153 > src/slave/flags.cpp 1eccea920338032173be4df6c374ec50dbd2eaf3 > src/tests/containerizer/provisioner_appc_tests.cpp > 8b4b832a8fc022435b4d1ada8b8fd9c392ce685e > > Diff: https://reviews.apache.org/r/50871/diff/ > > > Testing > ------- > > make check > > sudo ./bin/mesos-tests.sh > > > Thanks, > > Gilbert Song > >