> On Jan. 11, 2017, 10:23 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/src/tests/CMakeLists.txt, lines 80-81 > > <https://reviews.apache.org/r/55030/diff/1/?file=1591744#file1591744line80> > > > > What's the effect of adding these `source_groups` in multiple CMake > > lists? > > > > Is the only effect that each subproject in MSVC will show the files in > > an organized way?
The effect is that they're organized in every IDE, not just VS. (Also, please let me know if the commit message needs to be massaged for this to make sense.) - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55030/#review161306 ----------------------------------------------------------- On Dec. 25, 2016, 5:39 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55030/ > ----------------------------------------------------------- > > (Updated Dec. 25, 2016, 5:39 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, John Kordich, > and Joseph Wu. > > > Bugs: MESOS-3542 > https://issues.apache.org/jira/browse/MESOS-3542 > > > Repository: mesos > > > Description > ------- > > Currently in IDEs such as XCode and Visual Studio, all mesos source > files are grouped into one huge folder, with no attempt made to reflect > the hierarchy of folders that exist on disk. > > This commit groups libprocess files into relevant source groups so that > they appear in a sensible directory structure in these IDEs. > > In addition to beginning to directly address MESOS-3542, this is also > (indirectly) the first step towards addressing the problem of breaking > libmesos up into smaller binaries (MESOS-3542). > > > Diffs > ----- > > 3rdparty/libprocess/cmake/ProcessConfigure.cmake > 873f41d844faa0d442f77411e94314a89be5f046 > 3rdparty/libprocess/src/CMakeLists.txt > 60f0e76dfd237d9a12a366b413802d1a96892b55 > 3rdparty/libprocess/src/tests/CMakeLists.txt > 4b80c397381ca2c869cd6eb7507bb9df94ce3623 > > Diff: https://reviews.apache.org/r/55030/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
