> On Jan. 12, 2017, 3:50 p.m., Alexander Rojas wrote: > > src/tests/api_tests.cpp, lines 3619-3659 > > <https://reviews.apache.org/r/55464/diff/1/?file=1603868#file1603868line3619> > > > > Why not replacing this test with one that shows the opposite?
I added a test that launches parent and child containers nested under an executor, kills them and waits for them to be completed. - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55464/#review161391 ----------------------------------------------------------- On Jan. 13, 2017, 10:08 a.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55464/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2017, 10:08 a.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, > Alexander Rojas, and haosdent huang. > > > Bugs: MESOS-6864 > https://issues.apache.org/jira/browse/MESOS-6864 > > > Repository: mesos > > > Description > ------- > > Made the Agent API able to handle containers nested at arbitrary levels. > > > Diffs > ----- > > src/slave/http.cpp 24fc23b229c624835a24cdda9587c99c6ac9c3bb > src/slave/slave.cpp 11e8833fd5998abb71a7bb08e5dec451d894aba9 > src/tests/api_tests.cpp ea62226fbc5dd0bcc5ea60d1bbcd3748f9367467 > > Diff: https://reviews.apache.org/r/55464/diff/ > > > Testing > ------- > > `GTEST_FILTER="" make -j 8 check` in macOS. > `make check` in Linux. > > I also did some manual testing using a proof of concept that makes the > `DefaultExecutor` leverage this change to perform CMD health checks. > > > Thanks, > > Gastón Kleiman > >
