----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55252/ -----------------------------------------------------------
(Updated Jan. 16, 2017, 2:30 p.m.) Review request for mesos, Anand Mazumdar, Benjamin Bannier, Benjamin Mahler, and Guangya Liu. Changes ------- rebase and squashed previous patch into this one to make the review more readable. Summary (updated) ----------------- Refactored `roles()` and `getRoles()` to reuse common logic. Bugs: MESOS-6855 https://issues.apache.org/jira/browse/MESOS-6855 Repository: mesos Description (updated) ------- Some common logic are extracted into two new methods `filterRoles` and `_getRoles`, which can be reused by both v0 and v1 APIs. This is a step toward adding 'roles' section into '/state' endpoint. Diffs (updated) ----- src/master/http.cpp a44621f39cb059e654a56f57f75b38947f3a4230 src/master/master.hpp 44f4fecb1fbe8bebf830990a59a5462338e6e004 Diff: https://reviews.apache.org/r/55252/diff/ Testing ------- Thanks, Jay Guo