----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55637/#review162032 -----------------------------------------------------------
Patch looks great! Reviews applied: [55022, 55023, 55024, 55030, 55037, 55038, 55039, 55040, 55161, 55162, 55311, 55312, 55313, 55314, 55327, 55328, 55543, 55544, 55546, 55547, 55548, 55549, 55550, 55599, 55600, 55601, 55602, 55604, 55607, 55632, 55635, 55636, 55637] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos ReviewBot On Jan. 17, 2017, 7:33 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55637/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2017, 7:33 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. > > > Bugs: MESOS-3697 > https://issues.apache.org/jira/browse/MESOS-3697 > > > Repository: mesos > > > Description > ------- > > This commit will introduce a `test` target to the CMake build system. > The semantics of this target are very similar to the autotools build > system, in that they build the tests, but do not run them. > > Accomplishing this is somewhat complex in CMake, because CMake expects > to control the `test` target itself. We work around this by (1) > silencing the warning that `test` is a reserved target, (2) removing the > call to `enable_testing` that sets up CTest, and (3) adding our own > `test` target. As an additional insurance policy, we error out if any of > the `BUILD_TESTING` flags are defined, which would indicate that > `include(CTest)` was called. > > > Diffs > ----- > > CMakeLists.txt c6b1eb6a7c7e6ed3650847acbec0ddd3101bb96f > cmake/MesosConfigure.cmake 6a9ed9dc02f5c9a6d1fce0866f19ffeafec35cdc > src/tests/CMakeLists.txt b7adf4f3126611a57baf4f62b62b208bc0236da5 > > Diff: https://reviews.apache.org/r/55637/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
