----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55312/#review162189 -----------------------------------------------------------
Ship it! `CREATE_JOB` code can use a few minor tweaks, which I'll make before committing. 3rdparty/libprocess/src/subprocess.cpp (lines 62 - 70) <https://reviews.apache.org/r/55312/#comment233442> I'm going to move most of this comment into the definition of the function, as a header comment. 3rdparty/libprocess/src/subprocess.cpp (lines 75 - 77) <https://reviews.apache.org/r/55312/#comment233453> Remove the `else` here, but keep the `return`. - Joseph Wu On Jan. 18, 2017, 12:49 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55312/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2017, 12:49 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > The subprocess API exposes various hooks to customize behavior as we > create the child process. Currently, these hooks are unimplemented in > the Windows codepaths. This commit will implement the parent hooks -- > which are executed after the child process is created, but before it > begins execution -- on the Windows codepath. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/subprocess_base.hpp > 74a4bef0706334b4d3c1040a08a8921fbc300344 > 3rdparty/libprocess/include/process/windows/subprocess.hpp > 3bc7f1992d9c38dac2ec23d5bc57415f37d0318a > 3rdparty/libprocess/src/subprocess.cpp > ad19b0896b4a2e9c60f573cc854c10c69e909e86 > > Diff: https://reviews.apache.org/r/55312/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
