> On Jan. 22, 2017, 2:09 p.m., Jie Yu wrote: > > src/linux/fs.cpp, line 103 > > <https://reviews.apache.org/r/55714/diff/2/?file=1610382#file1610382line103> > > > > `s/_typeName/names/` > > > > or > > > > `s/_typeName/typeNames/`
I would prefer `typeNames`. Thanks! - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55714/#review162582 ----------------------------------------------------------- On Jan. 20, 2017, 2:11 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55714/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2017, 2:11 a.m.) > > > Review request for mesos, Avinash sridharan, Jie Yu, James Peach, Timothy > Chen, and Jiang Yan Xu. > > > Bugs: MESOS-6958 > https://issues.apache.org/jira/browse/MESOS-6958 > > > Repository: mesos > > > Description > ------- > > A simple uint32_t -> string mapping for filesystem type. > > > Diffs > ----- > > src/linux/fs.hpp da49c9ebfa938d169152ed3b6e4df7378711b013 > src/linux/fs.cpp 913e23317291db164fe6bdf77f3eca146dedec9b > > Diff: https://reviews.apache.org/r/55714/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
