----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53998/#review162967 -----------------------------------------------------------
Ping. Do we still need this? - Adam B On Nov. 22, 2016, 12:26 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53998/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2016, 12:26 p.m.) > > > Review request for mesos, Adam B, Jie Yu, Kapil Arya, and Joseph Wu. > > > Bugs: MESOS-6396 > https://issues.apache.org/jira/browse/MESOS-6396 > > > Repository: mesos > > > Description > ------- > > When being used on a task run by a command executor, the hook > `slavePreLaunchDockerEnvironmentDecorator` did not allow for extending > the executor's own environment but only the environment of the task. > By using the hook returned environment for the executor in any case > and supplying a task specific environment for the command executor, > that limitation is fixed. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp c2ed5240aab9ea9d1a386c44c94e5ae7e98d313c > > Diff: https://reviews.apache.org/r/53998/diff/ > > > Testing > ------- > > make check > > * WIP - functional testing pending - WIP * > > > Thanks, > > Till Toenshoff > >
