----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review163070 -----------------------------------------------------------
Fix it, then Ship it! Just a minor comment plus the reply to a previous comment. src/examples/persistent_volume_framework.cpp (lines 248 - 249) <https://reviews.apache.org/r/45962/#comment234504> This ``` } else { if (...) { } } ``` looks odd. You could have done `else if` but in this particular case I guess `break` sonner is better? (A simple condition check + keep the bulk of the logic less indented). - Jiang Yan Xu On Jan. 9, 2017, 2:37 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45962/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2017, 2:37 p.m.) > > > Review request for mesos, Greg Mann, Jie Yu, and Jiang Yan Xu. > > > Bugs: MESOS-4431 > https://issues.apache.org/jira/browse/MESOS-4431 > > > Repository: mesos > > > Description > ------- > > Updated a persistent volume test framework to include shared volumes. > > > Diffs > ----- > > src/examples/persistent_volume_framework.cpp > 9d45bb496c4cf378af429b5aa970bf81450e482a > > Diff: https://reviews.apache.org/r/45962/diff/ > > > Testing > ------- > > New test framework for shared resources added. > Tests successful. > > > Thanks, > > Anindya Sinha > >
