> On Jan. 24, 2017, 4:27 p.m., Joseph Wu wrote: > > 3rdparty/stout/cmake/StoutConfigure.cmake, line 47 > > <https://reviews.apache.org/r/55600/diff/2/?file=1606435#file1606435line47> > > > > Why not use `*.hpp` instead? > > Alex Clemmer wrote: > Generally, we also would like to include .h files generated by protobufs, > either those that exist, or those that might exist in the future. In Stout, > for example, there is `protobuf_tests.proto` in the `tests/` folder. The > Stout headers don't have any .proto files that I know of right now, but I > think it's better just to use this one pattern everywhere.
Ok, but let's be explicit, say `*.h(pp)?`. Otherwise, we'll be matching against `.hooligans` and `.hoopla` :) Similar below. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55600/#review162882 ----------------------------------------------------------- On Jan. 16, 2017, 10:41 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55600/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2017, 10:41 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Stout currently manually groups its source code by folder in order to > present the source nicely in IDEs like XCode and Visual Studio. > > With the recently-introduced CMake function, `GROUP_SOURCE`, this > process is automated away. This commit will remove these manual groups > and replace it with a call to this function. > > > Diffs > ----- > > 3rdparty/stout/cmake/StoutConfigure.cmake > bc27ac687bae4e1798eece562027ba33c6b32348 > 3rdparty/stout/tests/CMakeLists.txt > a8a3ac772aa243c848a6fd8d7a0d45acfe1b98ae > > Diff: https://reviews.apache.org/r/55600/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >