> On Jan. 25, 2017, 6:15 a.m., Avinash sridharan wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, line 945 > > <https://reviews.apache.org/r/55790/diff/1/?file=1610974#file1610974line945> > > > > why do a `dns.Clear()`?
Consistency. Each block is the same and it remove the risk of breakage from reordering or adding new checks. > On Jan. 25, 2017, 6:15 a.m., Avinash sridharan wrote: > > src/tests/containerizer/cni_isolator_tests.cpp, line 950 > > <https://reviews.apache.org/r/55790/diff/1/?file=1610974#file1610974line950> > > > > nameservers should be IP addresses? Otherwise it becomes a chicken and > > egg problem. Sure, but there's no enforcement of this in any of the API layers. From the perspective of the tests this is an arbitrary string. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55790/#review162760 ----------------------------------------------------------- On Jan. 26, 2017, 11:19 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55790/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2017, 11:19 p.m.) > > > Review request for mesos, Avinash sridharan, Jie Yu, and Jiang Yan Xu. > > > Bugs: MESOS-6858 > https://issues.apache.org/jira/browse/MESOS-6858 > > > Repository: mesos > > > Description > ------- > > Add support for the full set of DNS resolver configuration items that > a CNI IPAM plugin can specify. This implements updating the container's > resolv.conf with the 'domain', 'search', and 'options' keywords. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 84dc157e7d9e332a6da0f1fc33303e9ef9bdc147 > src/slave/containerizer/mesos/isolators/network/cni/spec.hpp > ccd511ec14810dcc1020dec5e1641141f3a319b4 > src/slave/containerizer/mesos/isolators/network/cni/spec.cpp > ac48159dadcea422f605e723db94a7f3bb573fa2 > src/tests/containerizer/cni_isolator_tests.cpp > cb893d3ef005a9cc60c40768fa669b27c4863020 > > Diff: https://reviews.apache.org/r/55790/diff/ > > > Testing > ------- > > sudo make check (Fedora 25) > > > Thanks, > > James Peach > >