----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55955/ -----------------------------------------------------------
(Updated Jan. 28, 2017, 11:35 p.m.) Review request for mesos, Jan Schlicht and Vinod Kone. Bugs: MESOS-6991 https://issues.apache.org/jira/browse/MESOS-6991 Repository: mesos Description ------- The `value` field within `Environment::Variable` is being changed to `optional`, but for the time being we will enforce that it must be set for backward compatibility. This patch adds tests to ensure that environment variables with unset values are correctly rejected. Diffs (updated) ----- src/tests/check_tests.cpp c88cd34fd214f111cff62591aa5fc03eb62567e4 src/tests/health_check_tests.cpp debbd3c09b7555145aaf3f62a24d795d1423a269 src/tests/master_validation_tests.cpp edb57407e08cdbd8fbf10a9e1493cab3b4979bb8 src/tests/slave_validation_tests.cpp 5de771114982751e7796f55dcacd4384c6989efb Diff: https://reviews.apache.org/r/55955/diff/ Testing ------- bin/mesos-tests.sh --gtest_filter="*Validation*" Thanks, Greg Mann