----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56087/#review163852 -----------------------------------------------------------
Ship it! LGTM! Thanks for the patches, Ilya! Could you add `MESOS-7046` to `BUG` in your patches? And just let you know that you can post your patches as a chain using `support/post-reviews.py`. - Gilbert Song On Jan. 30, 2017, 9:28 a.m., Ilya Pronin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56087/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2017, 9:28 a.m.) > > > Review request for mesos, Benjamin Mahler and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Repalced manual `std::map` contents hashing with specialized > `boost::hash_combine()`. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/appc/cache.cpp > fed5ae97419d5eb9611a6fd1ade1bbed7ed440a2 > > Diff: https://reviews.apache.org/r/56087/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Ilya Pronin > >