----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56178/#review164109 -----------------------------------------------------------
src/authorizer/local/authorizer.cpp (line 240) <https://reviews.apache.org/r/56178/#comment235689> Does this return a list with a single role, if the framework fills in `framework_info.role` instead of `framework_info.roles`? Is there a reason you can't just use `framework_info.roles()` here instead of using the protobuf util? src/authorizer/local/authorizer.cpp (line 243) <https://reviews.apache.org/r/56178/#comment235690> Seems like framework_info is always set, so how/why would we ever fall through to the other cases? src/master/master.cpp (line 2175) <https://reviews.apache.org/r/56178/#comment235687> s/use/used/ - Adam B On Feb. 1, 2017, 9:06 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56178/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2017, 9:06 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler. > > > Bugs: MESOS-7022 > https://issues.apache.org/jira/browse/MESOS-7022 > > > Repository: mesos > > > Description > ------- > > This updates the local authorizer so that MULTI_ROLE frameworks can be > authorized. > > For non-MULTI_ROLE frameworks we continue to support use of the > deprecated 'value' field in the authorization request's 'Object'; > however for MULTI_ROLE frameworks the 'value' field will not be set, > and authorizers still relying on it should be updated to instead use > the object's 'framework_info' field to extract roles to authorize > against from. > > > Diffs > ----- > > src/authorizer/local/authorizer.cpp > b98e1fcdf2ee5ec1f6ac0be6f8accdefaa390a09 > src/master/master.cpp 284566ca72bd5c6bd581db9b65d404f86aa7bf61 > > Diff: https://reviews.apache.org/r/56178/diff/ > > > Testing > ------- > > Tested on various configurations in internal CI. > > > Thanks, > > Benjamin Bannier > >
